Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support enums in go runtime #1006

Merged
merged 1 commit into from
Mar 6, 2024
Merged

feat: support enums in go runtime #1006

merged 1 commit into from
Mar 6, 2024

Conversation

worstell
Copy link
Contributor

@worstell worstell commented Mar 2, 2024 •
edited
Loading

No description provided.

@worstell worstell force-pushed the worstell/20240301-go-runtime-enums branch from a9b0029 to a470f0d Compare March 2, 2024 03:02
@worstell worstell force-pushed the worstell/20240301-go-runtime-enums branch 4 times, most recently from 5871fae to 5b76118 Compare March 2, 2024 03:50
alecthomas
alecthomas approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good! Don't forget to announce once it's released!

buildengine/build_go_test.go Show resolved Hide resolved
buildengine/build_kotlin.go Show resolved Hide resolved
buildengine/build_kotlin_test.go Show resolved Hide resolved
go-runtime/compile/build.go Outdated Show resolved Hide resolved
go-runtime/compile/schema.go Outdated Show resolved Hide resolved
go-runtime/compile/schema.go Outdated Show resolved Hide resolved
go-runtime/compile/schema.go Outdated Show resolved Hide resolved
go-runtime/compile/testdata/one/one.go Outdated Show resolved Hide resolved
@alecthomas alecthomas mentioned this pull request Mar 5, 2024
Open
@worstell worstell force-pushed the worstell/20240301-go-runtime-enums branch from 5b76118 to a551877 Compare March 6, 2024 19:44
alecthomas
alecthomas reviewed Mar 6, 2024
View reviewed changes
backend/schema/validate.go Outdated Show resolved Hide resolved
backend/schema/validate.go Outdated Show resolved Hide resolved
@worstell worstell force-pushed the worstell/20240301-go-runtime-enums branch 3 times, most recently from e3961c1 to c0a326c Compare March 6, 2024 20:52
@worstell worstell force-pushed the worstell/20240301-go-runtime-enums branch from c0a326c to 0c71953 Compare March 6, 2024 20:59
@worstell worstell merged commit 714fe0c into main Mar 6, 2024
11 checks passed
@worstell worstell deleted the worstell/20240301-go-runtime-enums branch March 6, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@dhanji dhanji Awaiting requested review from dhanji

@wesbillman wesbillman Awaiting requested review from wesbillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worstell @alecthomas